[PATCH] D39471: [asan] Fix small X86_64 ShadowOffset for non-default shadow scale

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 14:31:19 PST 2017


eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:293
                                    cl::desc("scale of asan shadow mapping"),
                                    cl::Hidden, cl::init(0));
 
----------------
vitalybuka wrote:
> @eugenis why do we need 0 here and not just kDefaultShadowScale
No idea. Looks strange. Check code history?


https://reviews.llvm.org/D39471





More information about the llvm-commits mailing list