[PATCH] D40087: [CMake][runtimes] Use cmake_parse_arguments in runtimes functions

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 14:06:49 PST 2017


beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

LGTM.

Generally we frown on commit messages as concise as your description here. Might be worth a quick sentence or two explaining why `cmake_parse_aguments` is better as a breadcrumb for anyone who comes along in the future.


Repository:
  rL LLVM

https://reviews.llvm.org/D40087





More information about the llvm-commits mailing list