[PATCH] D40078: [x86][icelake]VAES introduction

[coby via Phabricator via llvm-commits]

coby added inline comments.


================
Comment at: lib/Target/X86/X86.td:174
+                       "Promote selected AES instructions to AVX512/AVX registers",
+                        [FeatureAVX]>;
 def FeatureTBM     : SubtargetFeature<"tbm", "HasTBM", "true",
----------------
craig.topper wrote:
> Should this imply FeatureAES as well?
not sure,
it has no direct dependency afaiu, like AVX, for example, i.e. it does not imply that AES insns are apparent.
practically, if you want to use 'vaesenc', for example, you ought to have a Key, so you'll probably want to use 'aeskeygenassist' which is on AES solely, but than again - it (vaes) may still be provided on its own, so I find it yet questionable




Repository:
  rL LLVM

https://reviews.llvm.org/D40078