[PATCH] D40074: [GISel] Canonicalize constants to RHS for commutative operations

Noel Grandin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 11:26:47 PST 2017


grandinj added a comment.

In https://reviews.llvm.org/D40074#926085, @kristof.beyls wrote:

> If this is the first canonicalization (of potentially many to come) in the IRTranslator, would it make sense to try and document the canonical representation(s) somewhere and/or somehow?


Even better would be a pass that verified canonical order, that could be inserted between other passes in debug mode to verify that optimisations preserve canonical-ness


https://reviews.llvm.org/D40074





More information about the llvm-commits mailing list