[PATCH] D40061: [WIP] [ARM] Make MachineVerifier more strict about terminators

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 10:58:57 PST 2017


MatzeB added a comment.

Uh, I wasn't aware that if-conversion could produce terminator instructions in the middle of a basic block, and I would suspect this to break other things like MachineBasicBlock::isReturnBlock() which assume terminators are at the end...

I must admit I don't understand how a change in `analyzeBranch()` allows you to drop that MachineVerifier special case. But I am all for dropping strange special cases in the machine verifier :)


Repository:
  rL LLVM

https://reviews.llvm.org/D40061





More information about the llvm-commits mailing list