[PATCH] D40037: [CallSiteSplitting] Remove some indirection (NFC).

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 10:54:04 PST 2017


davidxl added a comment.

In https://reviews.llvm.org/D40037#925314, @junbuml wrote:

> Thanks Florian for cleaning up this pass.  Overall look good, but this doesn't seem a NFC and can miss an opportunity for a constant phi in non-OR  structure. Please see my inline comments.


Just a side comment -- this looks more and more like more general code cloning optimization to enable constant/range propagations -- may want to consider rename the pass and make it more general.


https://reviews.llvm.org/D40037





More information about the llvm-commits mailing list