[PATCH] D35192: [ARM] Use ADDCARRY / SUBCARRY

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 10:04:48 PST 2017


rogfer01 added a comment.

A combiner kicks in for `t33` because it is of the form `(add, X, (addcarry Y, 0, C)` and then it becomes `(addcarry X, Y, C)` which looks correct but I think it interacts badly with the nodes `t24`, `t44` and `t42` (which also have similar forms).

If my reading is correct, after this combination the final `carry7` is not computed.

@deadalnix  can you take a look at the screenshot above to check if my findings make sense?


Repository:
  rL LLVM

https://reviews.llvm.org/D35192





More information about the llvm-commits mailing list