[PATCH] D40019: [LLD] [MinGW] Implement the --[no-]gc-sections and --icf options

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: MinGW/Driver.cpp:173
     Add("-tsaware:no");
   if (Args.hasArg(OPT_high_entropy_va))
     Add("-highentropyva");
----------------
ruiu wrote:
> Please add a blank line before a new if ~ else if ~ else block.
This is context from another one of the diffs that later was revised - I think it looks better now.


================
Comment at: MinGW/Driver.cpp:188
+    else
+      Add("-opt:noicf");
+  } else {
----------------
ruiu wrote:
> Don't you want to report an error for an unknown argument?
I guess that could be good as well, will update the diff.


https://reviews.llvm.org/D40019