[PATCH] D39823: GlobalISel: Enable the legalization of G_MERGE_VALUES and G_UNMERGE_VALUES

Volkan Keles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 16:08:25 PST 2017


volkan marked 2 inline comments as done.
volkan added inline comments.


================
Comment at: lib/Target/AArch64/AArch64LegalizerInfo.cpp:359
+  for (const auto &Ty :
+       {s32, s64, s96, s128, s192, v2s32, v3s32, v4s32, v2s64, v4s64, v6s64}) {
+    setAction({G_MERGE_VALUES, Ty}, Legal);
----------------
kristof.beyls wrote:
> I haven't thought this through at all, but I'm a bit surprised v8s64 also isn't legal if v6s64 is?
> Similarly for S256 if s192 is legal?
Added missing cases.


https://reviews.llvm.org/D39823





More information about the llvm-commits mailing list