[PATCH] D40035: [LoopRotate] processLoop should return true even if it just simplified the loop latch without making any other changes

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

I'm under the impression the fix is correct, a couple of comments inline.



================
Comment at: test/Transforms/LoopRotate/pr35210.ll:1
+;RUN: opt %s -passes='adce,loop(rotate),adce' -S -debug-pass-manager -debug-only=loop-rotate 2>&1 | FileCheck %s
+
----------------
I don't remember this exactly, but DEBUG implies `REQUIRES: assert?`


================
Comment at: test/Transforms/LoopRotate/pr35210.ll:17
+; CHECK-NEXT: Running analysis: TargetIRAnalysis on f
+; CHECK-NEXT: Running analysis: InnerAnalysisManagerProxy<llvm::LoopAnalysisManager, llvm::Function> on f
+; CHECK-NEXT: Starting Loop pass manager run.
----------------
Please make sure this passes on Windows, because there have been problems (you might want to use just <*> as other tests do). 


https://reviews.llvm.org/D40035