[PATCH] D40048: [asan] Prevent rematerialization of &__asan_shadow.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:216
+
+static cl::opt<bool> ClWithIfuncSuppressRemat(
+    "asan-with-ifunc-suppress-remat",
----------------
eugenis wrote:
> pcc wrote:
> > Does this need to be a flag? Could we instead do this only on arm32?
> Flag is useful for benchmarking and also as a way to disable this feature if something goes wrong. We already do this only on android/arm32.
Please at least remember to remove this flag once you know that it works well.


https://reviews.llvm.org/D40048