[llvm] r318190 - [llvm-objcopy] Improve command line option help messages

Jake Ehrlich via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 12:36:04 PST 2017


Author: jakehehrlich
Date: Tue Nov 14 12:36:04 2017
New Revision: 318190

URL: http://llvm.org/viewvc/llvm-project?rev=318190&view=rev
Log:
[llvm-objcopy] Improve command line option help messages

I was being inconsistent with the way I was capitalizing help messages
for command line options. Additionally --remove-section wasn't using
value_desc even though it benefited from it.

Differential Revision: https://reviews.llvm.org/D39978

Modified:
    llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp

Modified: llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp?rev=318190&r1=318189&r2=318190&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp (original)
+++ llvm/trunk/tools/llvm-objcopy/llvm-objcopy.cpp Tue Nov 14 12:36:04 2017
@@ -75,10 +75,11 @@ static cl::opt<std::string> InputFilenam
 static cl::opt<std::string> OutputFilename(cl::Positional, cl::desc("<output>"),
                                     cl::init("-"));
 static cl::opt<std::string>
-    OutputFormat("O", cl::desc("set output format to one of the following:"
+    OutputFormat("O", cl::desc("Set output format to one of the following:"
                                "\n\tbinary"));
 static cl::list<std::string> ToRemove("remove-section",
-                                      cl::desc("Remove a specific section"));
+                                      cl::desc("Remove <section>"),
+                                      cl::value_desc("section"));
 static cl::alias ToRemoveA("R", cl::desc("Alias for remove-section"),
                            cl::aliasopt(ToRemove));
 static cl::opt<bool> StripAll("strip-all",
@@ -90,13 +91,13 @@ static cl::opt<bool> StripSections("stri
 static cl::opt<bool> StripNonAlloc("strip-non-alloc",
                                    cl::desc("Remove all non-allocated sections"));
 static cl::opt<bool>
-    StripDWO("strip-dwo", cl::desc("remove all DWARF .dwo sections from file"));
+    StripDWO("strip-dwo", cl::desc("Remove all DWARF .dwo sections from file"));
 static cl::opt<bool> ExtractDWO(
     "extract-dwo",
-    cl::desc("remove all sections that are not DWARF .dwo sections from file"));
+    cl::desc("Remove all sections that are not DWARF .dwo sections from file"));
 static cl::opt<std::string>
     SplitDWO("split-dwo",
-             cl::desc("equivalent to extract-dwo on the input file to "
+             cl::desc("Equivalent to extract-dwo on the input file to "
                       "<dwo-file>, then strip-dwo on the input file"),
              cl::value_desc("dwo-file"));
 




More information about the llvm-commits mailing list