[PATCH] D40025: [LLD] [COFF] Always truncate the .eh_frame section name

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 10:45:40 PST 2017


smeenai added a comment.

In https://reviews.llvm.org/D40025#924844, @rnk wrote:

> I wonder if we should limit the long section name extension to sections that aren't mapped at runtime. This makes sense because if some tool cares about unmapped section contents, they're going to need to look at the file on disk, not the image in memory, and that will have a full symbol table.
>
> Does that make sense, or should we just go with this?


I'd be in favor of that. It'd be more consistent with link's behavior as well (I believe it always truncates).

8 characters ought to be enough for anybody :)


https://reviews.llvm.org/D40025





More information about the llvm-commits mailing list