[PATCH] D39985: [SCEV] Apply a single debug loc when expanding a SCEV

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: include/llvm/Analysis/ScalarEvolutionExpander.h:180
+    PHINode *getOrInsertCanonicalInductionVariable(const Loop *L,
+                                                   const DebugLoc &DbgLoc,
+                                                   Type *Ty);
----------------
aprantl wrote:
> I think DebugLoc is already a value type, so there is no point in passing it by reference.
Will fix.


================
Comment at: unittests/Analysis/ScalarEvolutionTest.cpp:32
+
+void PrintTo(const DebugLoc &L, ::std::ostream *os) {
+  std::string S;
----------------
aprantl wrote:
> is this used anywhere?
> the coding standard wants functions to begin with lower-case letters.
Yes, it's used by gtest. I'll add a comment.


https://reviews.llvm.org/D39985