[PATCH] D39982: [IRBuilder] Set the insert point and debug location together

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 19:10:27 PST 2017


aprantl added a comment.

Thanks, this is looking really good!



================
Comment at: lib/IR/IRBuilder.cpp:25
+  DebugLoc CurrentLoc =
+      InsertPt ? InsertPt->getDebugLoc() : getCurrentDebugLocation();
+
----------------
Is falling back to getCurrentDebugLocation() a good idea? This looks like the kind of magic default behavior that this patch tries to get rid of.


https://reviews.llvm.org/D39982





More information about the llvm-commits mailing list