[PATCH] D39950: [DebugInfo] Stable sort symbols to remove non-deterministic ordering

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 19:00:24 PST 2017


probinson added a comment.

The results suggest a different problem.  Emitting the aranges section should happen after the "kittens" and "rainbows" symbols are emitted.  If the symbols were emitted, they should have nonzero and unique order.  I don't see how shuffling the list can result in a different result for the aranges section.
Although MCStreamer::AssignFragment looks like it might be a victim of unspecified order-of-evaluation, still I would think the assigned orders remain nonzero and unique per symbol, and that's all that matters here.


Repository:
  rL LLVM

https://reviews.llvm.org/D39950





More information about the llvm-commits mailing list