[PATCH] D39084: [PM] Port BoundsChecking to the new PM.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc marked 2 inline comments as done.
chandlerc added a comment.

Thanks, landing with comments addressed.



================
Comment at: llvm/include/llvm/Transforms/Instrumentation/BoundsChecking.h:27
+// checking on loads, stores, and other memory intrinsics.
+FunctionPass *createBoundsCheckingLegacyPass();
+
----------------
davide wrote:
> We generally don't put the old `create*` API in the header, is there a particular reason why this is here?
I've been moving the create methods to the same header as the class. Otherwise, we end up in the awkward place where the .cpp file defines interfaces declared in two unrelated headers (MyPass.h and Scalar.h or whichever umbrella header had the createFoo.* thing originally).

We didn't do this very carefully though and so probably need to go and move a bunch more of these declarations to better header files.

(I chatted with Davide on IRC and this plan made sense to him...)


https://reviews.llvm.org/D39084