[PATCH] D39906: [InstCombine] Allowing GEP Instructions with loop Invariant operands to combine

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 17:19:36 PST 2017


mgrang added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:1707
+        // them out of the loop and combining will only create extra instructions.
+        if ((!(L->isLoopInvariant(GO1))) || (!(L->isLoopInvariant(SO1))) ||
+            (L->isLoopInvariant(Src->getOperand(0))))
----------------
Too many parentheses. Can be simplified:

```
if (!L->isLoopInvariant(GO1) || !L->isLoopInvariant(SO1) ||
    L->isLoopInvariant(Src->getOperand(0)))


https://reviews.llvm.org/D39906





More information about the llvm-commits mailing list