[PATCH] D39976: [AArch64] Consider the cost model when folding loads and stores

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:591
 
+static bool isMergeableLdStUpdate(MachineInstr &MI) {
+  // Do update merging. It's simpler to keep this separate from the above
----------------
This is just moving some code from `optimizeBlock`? If that's unrelated having this in a separate patch would make it slightly easier to review IMO :)


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1674
+bool
+AArch64LoadStoreOpt::tryToMergeLdStUpdate(MachineBasicBlock::iterator &MBBI) {
+  MachineInstr &MI = *MBBI;
----------------
This is just moving some code from `optimizeBlock`?


Repository:
  rL LLVM

https://reviews.llvm.org/D39976