[PATCH] D38175: [ARM] Make sure assembler rejects PC as an operand for VMOV.F16

[Andre Vieira via Phabricator via llvm-commits]

avieira added a comment.

In https://reviews.llvm.org/D38175#922636, @rengolin wrote:

> Just a nit, why did you call it `rGPR2`? If this is a noPC/noSP class, than a longer but more meaningful name like `rGPRnopcsp` would be preferable.


Sure, I just picked rGPR2 as a placeholder, I expect in the end of this to replace almost all rGPR's with this new one and then revisit the names. But rGPRnopcsp is just as good a placeholder, if not better.

> On the invalid register class errors, you may find that the isel/regalloc are annealed with the current register descriptions, so it may take a bit of a beating.
> 
> Don't forget to also look at Global ISel.

Given Oliver's comments I was able to find the location where that LDR-VMOV was being created in FastISel and changed it there. This fixed this particular issue, but I have also found other codegen changes due to register allocation that I need to go look at... even with instructions/code that uses no vmov's.

Thanks for the tips!


https://reviews.llvm.org/D38175