[PATCH] D39909: [ARM] Issue an eror when non-general-purpose registers used in address operands

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added a comment.

Hi Momchil,

I think your alternative patch is actually the right way to go here. The problem with doing this in ARMAsmParser::parseMemory and friends is that we can't reject SP and PC for instructions where they are not valid. Doing that here would require moving a lot more instruction-specific logic into these functions, which isn't going to scale well.

I have some WIP patches that do something similar to https://reviews.llvm.org/D39910, and also expand the diagnostics. These patches aren't complete (need to cover more operand types and more tests), but I'll send you a copy of them.


https://reviews.llvm.org/D39909