[PATCH] D39935: [tsan] Fix signal chaining

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 00:03:46 PST 2017


dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM with a nit



================
Comment at: compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:2309
+    uptr cb = (uptr)old->sigaction;
+    if (cb == (uptr)rtl_sigaction || cb == (uptr)rtl_sighandler) {
+      internal_memcpy(old, &old_stored, sizeof(*old));
----------------
I think we should at least zero old. Otherwise there is no way to distinguish when it's filled and when it's uninit garbage.


https://reviews.llvm.org/D39935





More information about the llvm-commits mailing list