[PATCH] D39922: Create a TempFile class

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 12 21:13:54 PST 2017


ruiu added inline comments.


================
Comment at: lib/Support/Path.cpp:773-774
+Error TempFile::discard() {
+  if (Done)
+    return Error::success();
+  Done = true;
----------------
I think that calling `keep` or `Done` more than once on an object should be an error because I can't think of a use case in which allowing it is useful.


https://reviews.llvm.org/D39922





More information about the llvm-commits mailing list