[PATCH] D39819: [cfi-verify] Add DOT graph printing for GraphResult objects.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: test/tools/llvm-cfi-verify/X86/dot-printing.s:7
+# CHECK-NEXT: digraph
+# CHECK-NEXT: {{^.*jbe.*->.*(callq +\*%rax|ud2).*$}}
+# CHECK-NEXT: {{^.*jbe.*->.*(callq +\*%rax|ud2).*$}}
----------------
It is hard to get a clear picture of what this test is testing for. Can you show me what your actual output is for this test?


================
Comment at: test/tools/llvm-cfi-verify/X86/dot-printing.s:12
+
+# CHECK: Expected Protected: 1 (100.00%)
+# CHECK: Unexpected Protected: 0 (0.00%)
----------------
I wouldn't test for this, presumably you have other tests for this functionality.


https://reviews.llvm.org/D39819