[PATCH] D39871: [arm] Fix Unnecessary reloads from GOT.

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM, assuming you've done appropriate testing.



================
Comment at: llvm/test/CodeGen/ARM/GlobalISel/arm-select-globals-pic.mir:59
     ; DARWIN-NOMOVT: [[G:%[0-9]+]]:gpr = LDRLIT_ga_pcrel_ldr {{.*}}@external_global :: (load 4 from got)
-    ; ELF: [[G:%[0-9]+]]:gpr = LDRLIT_ga_pcrel_ldr @external_global :: (load 4 from got)
+    ; ELF: [[G:%[0-9]+]]:gpr = LDRLIT_ga_pcrel_ldr target-flags(<unknown>) @external_global :: (load 4 from got)
 
----------------
It would be nice to implement getSerializableDirectMachineOperandTargetFlags() to make this clearer.


https://reviews.llvm.org/D39871