[PATCH] D39885: Disable GC and ICF when /debug is present

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 13:20:17 PST 2017


rnk added inline comments.


================
Comment at: lld/COFF/Driver.cpp:915
       }
+      if (S == "ref") {
+        Config->DoGC = true;
----------------
pcc wrote:
> I don't think this is right. It will mean that `/debug /opt:ref` will not enable ICF, which doesn't appear to be consistent with what link.exe does.
I have a fix, but we have to make this not do ICF: `link /debug /opt:noicf,ref`


https://reviews.llvm.org/D39885





More information about the llvm-commits mailing list