[PATCH] D39582: Add ELF dynamic symbol support to yaml2obj/obj2yaml

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

Mostly looks good to me, I want someone to review the ELFDumper and elf2yaml changes but the ELFYAML and yaml2elf changes look good. I just have one request about making .dynstr allocated (see inline).



================
Comment at: tools/yaml2obj/yaml2elf.cpp:661
+    Index = State.SN2I.get(".dynstr");
+    State.initStrtabSectionHeader(SHeaders[Index], ".dynstr", State.DotDynstr, CBA);
+  }
----------------
.dynstr needs to have SHF_ALLOC set as well


https://reviews.llvm.org/D39582