[llvm] r317730 - Let replaceVTableHolder accept any type.

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 08:37:20 PST 2017



> On Nov 10, 2017, at 5:37 AM, Tom Tromey <ttromey at mozilla.com> wrote:
> 
>>>>>> ">" == Yung, Douglas <douglas.yung at sony.com> writes:
> 
>>> target triple = "x86_64-unknown-linux-gnu"
>>> This causes it to fail on compilers that do not include x86 as a target:
>>> http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/12905
>>> Perhaps this test should be moved to the X86 directory?
> 
> Sorry about that.  If I just remove that line, will it work?  It does
> here but that doesn't mean a whole lot I suppose.

No, that will break Darwin bots, because the file depends on features only available on ELF. I moved it to the X86 directory.

-- adrian

> 
> This test is really just checking some debuginfo bits; and I'm unversed
> in the ins and outs of editing .ll files to make them suitable test
> cases.  So I could use some guidance.
> 
> Tom



More information about the llvm-commits mailing list