[PATCH] D39888: [lsan] Only use VM_MEMORY_OS_ALLOC_ONCE on Darwin versions that support it

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 07:38:04 PST 2017


fjricci added a reviewer: kubamracek.
fjricci requested changes to this revision.
fjricci added a subscriber: kubamracek.
fjricci added a comment.
This revision now requires changes to proceed.

Because macOS changes quite a bit from version to version, we (or at least I) don't have strong plans to support LSan outside of 10.11+. Not sure what darwin used to store singleton kernel allocations before this page was introduced, but I assume that just not handling those allocations will lead to a ton of false positives. I'm inclined to let this fail on old versions unless there's someone willing to do the work to make sure they're properly supported. cc @kubamracek


https://reviews.llvm.org/D39888





More information about the llvm-commits mailing list