[PATCH] D39854: [DWARFv5] Support FORM_strp in .debug_line.dwo

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 06:45:15 PST 2017


JDevlieghere added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:341
+    DWARFDataExtractor LineData(*DObj, DObj->getLineSection(), isLittleEndian(),
+                                0);
+    while (Offset < LineData.getData().size()) {
----------------
Why don't we need the address byte size here anymore? I'm super excited you got rid of the "sketchy loop" below, but I'd like to understand why we can do without it. 


https://reviews.llvm.org/D39854





More information about the llvm-commits mailing list