[PATCH] D39508: [ubsan] lit changes for lld testing, future lto testing.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: test/lit.common.cfg:341
+
+config.clang = " " + " ".join(run_wrapper + [config.compile_wrapper, config.clang] + target_cflags + extra_cflags) + " "
+config.clangxx = " " + " ".join(run_wrapper + [config.compile_wrapper, config.clang] + target_cflags + config.cxx_mode_flags + extra_cflags) + " "
----------------
eugenis wrote:
> Now asan will add target_cflags twice: first here, then in asan/lig.cfg build_invocation.
> 
> Perhaps its better to keep compiler and flags in separate config variables, and let individual test projects join them. How about adding run_wrapper and compile_wrapper to config.clang, and -fuse-ld and lto_flags to config.target_cflags?
> 
> 
> Now asan will add target_cflags twice: first here, then in asan/lig.cfg build_invocation.
Yes, because i have only touched cfi and ubsan.
If these changes make sense, i would look into asan/msan next.

>How about adding run_wrapper and compile_wrapper to config.clang
https://reviews.llvm.org/D39508#inline-345840 - i.e. how do i do that?


Repository:
  rL LLVM

https://reviews.llvm.org/D39508