Re: [PATCH] D39567: [lit] Implement non-pipelined ‘mkdir’, ‘diff’ and ‘rm’ commands internally

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 9 19:42:51 PST 2017


Lgtm, thanks for working on this!
On Thu, Nov 9, 2017 at 1:59 PM Ying Yi via Phabricator <
reviews at reviews.llvm.org> wrote:

> MaggieYi updated this revision to Diff 122330.
> MaggieYi added a comment.
>
> Updated the builtin diff shell to support ‘-u’, ‘-b’ and ‘-w’ options.
> Now, all llvm, and clang tests passed with both Python 2 and Python 3.
>
>
> https://reviews.llvm.org/D39567
>
> Files:
>   lit/lit/TestRunner.py
>   lit/tests/Inputs/shtest-shell/check_path.py
>   lit/tests/Inputs/shtest-shell/diff-error-0.txt
>   lit/tests/Inputs/shtest-shell/diff-error-1.txt
>   lit/tests/Inputs/shtest-shell/diff-error-2.txt
>   lit/tests/Inputs/shtest-shell/diff-error-3.txt
>   lit/tests/Inputs/shtest-shell/diff-error-4.txt
>   lit/tests/Inputs/shtest-shell/diff-error-5.txt
>   lit/tests/Inputs/shtest-shell/diff-error-6.txt
>   lit/tests/Inputs/shtest-shell/mkdir-error-0.txt
>   lit/tests/Inputs/shtest-shell/mkdir-error-1.txt
>   lit/tests/Inputs/shtest-shell/mkdir-error-2.txt
>   lit/tests/Inputs/shtest-shell/rm-error-0.txt
>   lit/tests/Inputs/shtest-shell/rm-error-1.txt
>   lit/tests/Inputs/shtest-shell/rm-error-2.txt
>   lit/tests/Inputs/shtest-shell/rm-error-3.txt
>   lit/tests/Inputs/shtest-shell/valid-shell.txt
>   lit/tests/max-failures.py
>   lit/tests/shtest-shell.py
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171110/d443785d/attachment.html>


More information about the llvm-commits mailing list