[PATCH] D39287: Use CountingFunctionInserter both mcount and cygprofile calls, before and after inlining

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 9 16:34:26 PST 2017


rnk added a comment.

I think this is the way to go. Thanks! :)



================
Comment at: lib/Transforms/Utils/EntryExitInstrumenter.cpp:21-23
+namespace {
+
+void insertCall(Function &CurFn, StringRef Func, Instruction *InsertionPt) {
----------------
nit: mark these static, sink the anonymous namespace to the two pass structs.


================
Comment at: lib/Transforms/Utils/EntryExitInstrumenter.cpp:56
+
+bool runOnFunction(Function &F, bool PostInlining) {
+  StringRef EntryAttr = PostInlining ? "instrument-function-entry-inlined"
----------------
nit: static


https://reviews.llvm.org/D39287





More information about the llvm-commits mailing list