[PATCH] D39874: LTO: don't fatal when value for cache key already exists

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 9 16:09:59 PST 2017


pcc added inline comments.


================
Comment at: llvm/lib/LTO/Caching.cpp:83
+          int FD;
+          EC = sys::fs::openFileForRead(EntryPath, FD);
+          if (!EC) {
----------------
I think this can race with the cache pruner.

Maybe in this case you could create a copy of MBOrErr in memory, then close and delete the temporary file and return the copy to the client.


https://reviews.llvm.org/D39874





More information about the llvm-commits mailing list