[PATCH] D39670: [AMDGPU] Fix pointer info for pseudo source for r600

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 9 12:22:47 PST 2017


yaxunl added inline comments.


================
Comment at: lib/Target/AMDGPU/R600InstrInfo.cpp:1511
+  }
+  llvm_unreachable("Invalid pseudo source kind");
+  return AMDGPUASI.PRIVATE_ADDRESS;
----------------
arsenm wrote:
> Move unreachable into default and remove the final return
Doing this causes an error:

error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default]


https://reviews.llvm.org/D39670





More information about the llvm-commits mailing list