[compiler-rt] r317728 - [ThinLTO] New test needs to require LTO

[Teresa Johnson via llvm-commits]

On Thu, Nov 9, 2017 at 10:14 AM, Evgenii Stepanov <eugeni.stepanov at gmail.com
> wrote:

> It's failing on my desktop right now, because BFD is the default linker
> and there is nothing on the test run line to use gold or lld. I believe
> this is a common configuration.
>

It sounds like the best path forward is to revert this new test, then add
it again after adding support to test/asan/lit.cfg to use lto_flags. I can
then move it back to the OS-independent directory.


>
> On Wed, Nov 8, 2017 at 6:16 PM, Teresa Johnson <tejohnson at google.com>
> wrote:
>
>>
>>
>> On Wed, Nov 8, 2017 at 2:49 PM, Evgenii Stepanov <
>> eugeni.stepanov at gmail.com> wrote:
>>
>>> See config.lto_flags and tests/cfi/lit.cfg
>>>
>>> On Wed, Nov 8, 2017 at 2:47 PM, Evgenii Stepanov
>>> <eugeni.stepanov at gmail.com> wrote:
>>> > This also needs -fuse-ld=gold, at least.
>>>
>>
>> All the bots that were failing are now succeeding after adding the
>> REQUIRES. It would work with lld as well.
>>
>>
>>
>>> >
>>> > On Wed, Nov 8, 2017 at 1:48 PM, Teresa Johnson via llvm-commits
>>> > <llvm-commits at lists.llvm.org> wrote:
>>> >> Author: tejohnson
>>> >> Date: Wed Nov  8 13:48:27 2017
>>> >> New Revision: 317728
>>> >>
>>> >> URL: http://llvm.org/viewvc/llvm-project?rev=317728&view=rev
>>> >> Log:
>>> >> [ThinLTO] New test needs to require LTO
>>> >>
>>> >> Fix buildbot failures:
>>> >> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/bui
>>> lds/5262/steps/annotate/logs/stdio
>>> >>
>>> >> Modified:
>>> >>     compiler-rt/trunk/test/asan/TestCases/Linux/contiguous_cont
>>> ainer_crash_thinlto.cc
>>> >>
>>> >> Modified: compiler-rt/trunk/test/asan/Te
>>> stCases/Linux/contiguous_container_crash_thinlto.cc
>>> >> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/a
>>> san/TestCases/Linux/contiguous_container_crash_thinlto.cc?re
>>> v=317728&r1=317727&r2=317728&view=diff
>>> >> ============================================================
>>> ==================
>>> >> --- compiler-rt/trunk/test/asan/TestCases/Linux/contiguous_container_crash_thinlto.cc
>>> (original)
>>> >> +++ compiler-rt/trunk/test/asan/TestCases/Linux/contiguous_container_crash_thinlto.cc
>>> Wed Nov  8 13:48:27 2017
>>> >> @@ -6,6 +6,8 @@
>>> >>  //
>>> >>  // Test crash due to __sanitizer_annotate_contiguous_container.
>>> >>
>>> >> +// REQUIRES: lto
>>> >> +
>>> >>  #include <assert.h>
>>> >>  #include <string.h>
>>> >>
>>> >>
>>> >>
>>> >> _______________________________________________
>>> >> llvm-commits mailing list
>>> >> llvm-commits at lists.llvm.org
>>> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
>>
>> --
>> Teresa Johnson |  Software Engineer |  tejohnson at google.com |
>> 408-460-2413 <(408)%20460-2413>
>>
>
>


-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
<(408)%20460-2413>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171109/6489818d/attachment.html>