[PATCH] D39469: [asan] Add CMake hook to override default shadow scale

[Walter Lee via Phabricator via llvm-commits]

waltl added a comment.

In https://reviews.llvm.org/D39469#919760, @vitalybuka wrote:

> Just talked with @eugenis 
>  Maybe simpler approach is following:
>
> 1. we have llvm flag in AddressSanitizer.cpp which deppends on platform, 8 or 32
> 2. runtime also will pick 8 or 32 from platfor
> 3. if you'd like to setup build bot on e.g. x86 just to test 32, than you call add override flag like this. but it should be in compiler-rt only: e.g. COMPILER_RT_ASAN_SHADOW_GRANULARITY This flag can switch granularity of runtime and also add -mllvm -asan-shadow-granularity=32 for tests


That sounds good; I will work on it.  One followup question: the current flag is called -asan-shadow-scale.  Is that ok or should I change that to -asan-shadow-granularity?  I don't know if there are any users who depend on the existing name.


https://reviews.llvm.org/D39469