[PATCH] D37983: Add instruction subset for the ARC backend

Pete Couperus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 10:51:43 PST 2017


petecoup requested changes to this revision.
petecoup added a reviewer: kparzysz.
petecoup added a comment.
This revision now requires changes to proceed.

I don't personally feel strongly about either of these.
I'm generally trying to match the style in other backends, which on observation I thinke would either just implement the logic inline, or create a new static routine...and omit auto.
I was wrong on other details myself originally.
But, I'm also a newbie at this reviewing bit (like I somehow mistakenly marked this as accepted?), so I'm happy to be told otherwise.


Repository:
  rL LLVM

https://reviews.llvm.org/D37983





More information about the llvm-commits mailing list