[PATCH] D38417: [test-suite] Adding HACCKernels app

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 09:48:45 PST 2017


spatel added inline comments.


================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C++/HACCKernels/Makefile:4
+PROG     = HACCKernels
+FP_TOLERANCE = 0.00001
+CXXFLAGS = -ffast-math -DVERIFICATION_OUTPUT_ONLY=ON
----------------
That's not big enough? We're seeing a 0.001 difference in the output string. Is that wiggle acceptable for this program? How high can we go before we decide the result is bogus?

You can reproduce this locally if you have at least a Sandybridge to test on. Ie, if you specify -march=nehalem (or nothing), you should see "689.584" in the output, but if you specify -march=sandybridge, you should see "689.585". 

I don't know what underlying transforms cause that difference, but that seems like a reasonable error for -ffast-math.



https://reviews.llvm.org/D38417





More information about the llvm-commits mailing list