[PATCH] D39483: [CVP] Remove some {s|u}{add|sub}.with.overflow checks.

[Joel Galenson via Phabricator via llvm-commits]

jgalenson updated this revision to Diff 122110.
jgalenson added a comment.

I've done the rename, although I'll note that I slightly prefer the old name since it makes it obvious that the function only applies to overflow intrinsics, not any intrinsic.

As for changing ConstantRange, as I said before, I agree that should be done, but it seems to me like it should be done in a separate commit.  Once we have that, we should add a processSub (like processAdd), and we should add multiplication and division in all the places, but keeping focused commits seems like a better strategy to me.


https://reviews.llvm.org/D39483

Files:
  lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
  test/Transforms/CorrelatedValuePropagation/overflows.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39483.122110.patch
Type: text/x-patch
Size: 18568 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171108/083cb16e/attachment.bin>