[PATCH] D39607: [PartialInliner] Inline vararg functions that forward varargs.

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 05:18:03 PST 2017


grosser added a comment.

In https://reviews.llvm.org/D39607#919138, @fhahn wrote:

> In https://reviews.llvm.org/D39607#917790, @grosser wrote:
>
> > Officially accept this revision. From my perspective this looks good.
> >
> > Do you have some other partial inliner person who could give some additional feedback?
>
>
> I think it would be great if either @davidxl or @davide could sign-off on this.


Yes, this would be good, indeed!

I also like the suggestion from @davidxl to move the check into the extractor.


https://reviews.llvm.org/D39607





More information about the llvm-commits mailing list