[PATCH] D39700: [Builtins] Do not use tailcall for Thumb1

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 03:44:26 PST 2017


rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D39700#919089, @peter.smith wrote:

> With respect to this review specifically, I think that the change should make compiler-rt no worse and for its likely use case of v6-m, there aren't any non-core registers for the C language functions to corrupt. With respect to the larger problem of many of the other __aeabi_ functions calling C functions I think we should address separately to this Review.


agreed, not for this review.

> I have raised pr35243 to cover the non-compliance https://bugs.llvm.org/show_bug.cgi?id=35243 please feel to comment/correct as necessary.

Thanks!


https://reviews.llvm.org/D39700





More information about the llvm-commits mailing list