[PATCH] D39670: [AMDGPU] Fix pointer info for pseudo source for r600

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 00:58:14 PST 2017


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with the switch fix. Also could just move the SI one to AMDGPUInstrInfo



================
Comment at: lib/Target/AMDGPU/R600InstrInfo.cpp:1511
+  }
+  llvm_unreachable("Invalid pseudo source kind");
+  return AMDGPUASI.PRIVATE_ADDRESS;
----------------
Move unreachable into default and remove the final return


https://reviews.llvm.org/D39670





More information about the llvm-commits mailing list