[PATCH] D39670: [AMDGPU] Fix pointer info for pseudo source for r600

[Tom Stellard via Phabricator via llvm-commits]

tstellar added a comment.

In https://reviews.llvm.org/D39670#918887, @yaxunl wrote:

> We discussed this internally and concluded that having a static address space mapping is more important. Most of issues are due to using dummy pointer info. Such places should be few in r600 code, therefore we will continue fixing these issues unless we found there need excessive efforts to do so.


It would be nice to have these discussions on the mailing list so more people could participate, and it would be helpful for convincing people like me that this is the right approach, but as of right now I don't see why it is so important to have a static address space mapping that is the same for r600 and amdgcn.  I think the better approach would be to share less code between the two subtargets such that it's possible for each to have their own static mapping.  I think this kind of code separation is something should be done anyway independent of address space mapping work.


https://reviews.llvm.org/D39670