[PATCH] D39761: [Support] Make llvm::Error faster

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 18:38:18 PST 2017


Expected is a templated class
On Tue, Nov 7, 2017 at 6:36 PM Rui Ueyama via Phabricator <
reviews at reviews.llvm.org> wrote:

> ruiu added inline comments.
>
>
> ================
> Comment at: llvm/include/llvm/Support/Error.h:640
> +  LLVM_ATTRIBUTE_NOINLINE
> +  void fatalUncheckedExpected() const {
> +    dbgs() << "Expected<T> must be checked before access or
> destruction.\n";
> ----------------
> Maybe you should move this to a .cpp file as well?
>
>
> https://reviews.llvm.org/D39761
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171108/053aea1e/attachment.html>


More information about the llvm-commits mailing list