[PATCH] D39393: [asan] Use dynamic shadow on 32-bit Android.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 16:23:46 PST 2017


eugenis updated this revision to Diff 122012.
eugenis added a comment.

Lets go ahead with this, but keep using "legacy" dynamic shadow instrumentation.
Performance numbers of that mode aren't that bad and it solves the kernel compatibility issue.
By switching the runtime library to ifunc early, the future switch of instrumentation will not be an ABI break.

Speaking of ABI, I'm bumping the asan_version_mismatch thing on 32-bit android only. It looks a bit ugly,
but I think that not disturbing other platforms users is worth it.


https://reviews.llvm.org/D39393

Files:
  compiler-rt/lib/asan/CMakeLists.txt
  compiler-rt/lib/asan/asan_init_version.h
  compiler-rt/lib/asan/asan_linux.cc
  compiler-rt/lib/asan/asan_mapping.h
  compiler-rt/lib/asan/asan_premap_shadow.cc
  compiler-rt/lib/asan/asan_premap_shadow.h
  compiler-rt/lib/sanitizer_common/sanitizer_common.h
  compiler-rt/lib/sanitizer_common/sanitizer_flags.h
  compiler-rt/lib/sanitizer_common/sanitizer_fuchsia.cc
  compiler-rt/lib/sanitizer_common/sanitizer_linux.cc
  compiler-rt/lib/sanitizer_common/sanitizer_mac.cc
  compiler-rt/lib/sanitizer_common/sanitizer_win.cc
  llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39393.122012.patch
Type: text/x-patch
Size: 16782 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171108/b4eef9a5/attachment.bin>


More information about the llvm-commits mailing list