Re: [PATCH] D39737: [MC] Fix regression tests on Windows when git “core.autocrlf” is set to true

[Zachary Turner via llvm-commits]

Honestly this is exactly the reason I think core.autocrlf=false should be
required. A test whose correctness depends on a property of the source
control system is broken. What if someone is using svn, not git? Now that
needs a different solution
On Tue, Nov 7, 2017 at 2:43 PM Reid Kleckner via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> rnk added a comment.
>
> In https://reviews.llvm.org/D39737#918425, @caoz wrote:
>
> > Thanks Reid. The fix doesn't have regressions on Linux, as it supports
> both styles of line ending ("\r\n" and "\n").
>
>
> I'm sure it's possible to add regression tests that run on Linux with
> .gitattributes.
>
>
> https://reviews.llvm.org/D39737
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171107/4a684baf/attachment.html>