[PATCH] D39761: [Support] Make llvm::Error faster

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 14:13:43 PST 2017


hans added inline comments.


================
Comment at: llvm/include/llvm/Support/Error.h:256
+  LLVM_ATTRIBUTE_NOINLINE
+  void fatalUncheckedError() const {
+    dbgs() << "Program aborted due to an unhandled Error:\n";
----------------
Would it be better to put this in the .cpp file instead? Since it's not supposed to be inlined, there's no point in declaring it inline, I think.


https://reviews.llvm.org/D39761





More information about the llvm-commits mailing list