[PATCH] D39752: [ARM] Place jump table as the first operand in additions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 12:19:54 PST 2017


efriedma added a comment.

I understand what you're trying to do with the changes to ARMISelLowering.cpp make sense, but I'm surprised our address-matching code doesn't try to commute the operands.  Do we really not have code to do that somwhere?

I'm not sure what the change to ARMAsmPrinter.cpp is supposed to do; is it buggy, and nobody noticed because it never triggers?

I guess the change to ARMConstantIslandPass.cpp is just to match the new pattern we generate in Thumb1 mode?

Would this code be less confusing if we address the FIXME in ARMInstrInfo.td about using "addrmode2" in BR_JTm?


Repository:
  rL LLVM

https://reviews.llvm.org/D39752





More information about the llvm-commits mailing list