[PATCH] D39619: Correct atexit(3) support in TSan/NetBSD

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 04:23:30 PST 2017


dvyukov added inline comments.


================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:456
+    if (!res) {
+      ++AtExitStackSize;
+      if (InternalReallocArr(&AtExitStack, AtExitStackSize,
----------------
This needs a mutex.
at_exit_wrapper too. C++ allows concurrent callbacks, not sure if anybody does it, but at least it races with setup_at_exit_wrapper.


Repository:
  rL LLVM

https://reviews.llvm.org/D39619





More information about the llvm-commits mailing list